Conversation
| from enriching_population import EnrichingPopulation | ||
|
|
||
| if __name__ == "__main__": | ||
| print("hi") |
There was a problem hiding this comment.
@patricia-ternes @nickmalleson I have tested successfully the lastest code in this branch. I was able to run it for Leeds, and I have just a few comments that I have included in #9. Here are again my comments:
- I think the readme can also include some instructions on how o run the model., more like guide the user to going from one readme to another one. Or maybe the model can be wrapped in another folder structure.
- In the readme of /config, is there any way to run it to the whole local authorities?
- Once the required parameters are set, the rest of the text can be part of some section like
extended or expand the model to the users needs. - I replaced the hi print for another message.
mfbenitezp
left a comment
mfbenitezp
left a comment
There was a problem hiding this comment.
Great work. I could test it successfully and run it for Leeds, the results are included in the
#9
|
|
||
| # EPC credentials | ||
| epc_user: "user@email" | ||
| epc_key: "user_key" |
There was a problem hiding this comment.
In the readme I have included additional description, where users can understand epc_key means, the key_api https://epc.opendatacommunities.org/docs/api
| area_url: "https://www.arcgis.com/sharing/rest/content/items/8a824519215947da99146692b0a0ff49/data" | ||
|
|
||
| area_in_out: | ||
| - "pcds" |
There was a problem hiding this comment.
"pcds" # What does this represent?
There was a problem hiding this comment.
I tried to run the model for MSOA areas, should I remove the "oa11cd" and replace for the code of the msoa describes in the readme?
There was a problem hiding this comment.
So I update this file adding - "msoa11cd" as areas_in_out, but then I got this:
/Users/fbenitez/opt/anaconda3/envs/energyflex1/lib/python3.9/site-packages/causalinference/core/propensity.py:173: RuntimeWarning: invalid value encountered in sqrt
return np.sqrt(np.diag(np.linalg.inv(H)))
And the PS isn't working
|
Thanks for this @patricia-ternes . I think it'll take me a week to look at this, but as @mfbenitezp has already given really good comments I recommend merging now so you're not waiting for me. |
3 participants
PR overview
The folder
01-ActivityModel/activity-model/contains the code to create an enriched synthetic population.The instructions to install, configure and run the package are described in the README.md file.
The method data_preparation.Epc.remove_duplicates fix #5.
Reviewers
@nickmalleson and @mfbenitezp,
it would be wonderful if you could follow the instructions to download, install, configure and run the package, and give me any feedback on how the code works or about the instructions.
Thank you.